Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-10 01:51:03 +09:00
Code Activity

LibJS: Return the allocated dst register from deleting super properties

Browse source 
Even though calling delete on a super property will ultimately throw a
ReferenceError, we must return the allocated register for the result of
the delete operation (which would normally be a boolean). If the delete
operation is used in a return statement, the bytecode generator for the
return statement must be able to assume the statement had some output.
This commit is contained in:
Timothy Flynn 2024-12-13 11:50:55 -05:00 • committed by Tim Flynn
parent 18dddaa742
commit 5947c37637
Notes: github-actions[bot] 2024-12-14 20:09:41 +00:00
2 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibJS/Bytecode/Generator.cpp
View file

@ -812,7 +812,7 @@ CodeGenerationErrorOr<Optional<ScopedOperand>> Generator::emit_delete_reference(
emit<Bytecode::Op::DeleteByIdWithThis>(dst, *super_reference.base, *super_reference.this_value, identifier_table_ref); emit<Bytecode::Op::DeleteByIdWithThis>(dst, *super_reference.base, *super_reference.this_value, identifier_table_ref);
} }
return Optional<ScopedOperand> {}; return dst;
} }
auto object = TRY(expression.object().generate_bytecode(*this)).value(); auto object = TRY(expression.object().generate_bytecode(*this)).value();

11
Libraries/LibJS/Tests/operators/delete-basic.js
View file

@ -93,6 +93,13 @@ test("deleting super property", () => {
} }
} }
class D {
static foo() {
const deleter = () => delete super.foo;
deleter();
}
}
const obj = new B(); const obj = new B();
expect(() => { expect(() => {
obj.bar(); obj.bar();
@ -106,6 +113,10 @@ test("deleting super property", () => {
expect(() => { expect(() => {
C.foo(); C.foo();
}).toThrowWithMessage(ReferenceError, "Can't delete a property on 'super'"); }).toThrowWithMessage(ReferenceError, "Can't delete a property on 'super'");
expect(() => {
D.foo();
}).toThrowWithMessage(ReferenceError, "Can't delete a property on 'super'");
}); });
test("deleting an object computed property coerces the object to a property key", () => { test("deleting an object computed property coerces the object to a property key", () => {