Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-09 09:34:57 +09:00
Code Activity

Meta: Make all pre-commit CI scripts work with Bash 3.2

Browse source 
This change makes all the pre-commit CI scripts runnable under Bash 3.2,
by replacing “mapfile” invocations in them code that first explicitly
creates an array, and then uses a while loop to populate the array.

Otherwise, without this change, the scripts all fail to run under Bash
3.2 — due to lack of support for “mapfile”.

Fixes https://github.com/LadybirdBrowser/ladybird/issues/283

This also drops bash from the list of homebrew dependencies in the build
instructions — because with this change, homebrew bash (v4) is no longer
needed; things will now work with the Apple-provided bash (v3.2)
This commit is contained in:
sideshowbarker 2024-07-16 20:41:50 +09:00 • committed by Andrew Kaster
parent 4aba38e21f
commit 570814a31e
Notes: sideshowbarker 2024-07-17 01:53:23 +09:00
6 changed files with 21 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Documentation/BuildInstructionsLadybird.md
View file

@ -107,7 +107,7 @@ Xcode 14 versions before 14.3 might crash while building ladybird. Xcode 14.3 or
```
xcode-select --install
brew install autoconf autoconf-archive automake cmake ffmpeg nasm ninja ccache pkg-config bash
brew install autoconf autoconf-archive automake cmake ffmpeg nasm ninja ccache pkg-config
```
If you also plan to use the Qt chrome on macOS: