Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-09 09:34:57 +09:00
Code Activity

Kernel: Stop leaking TmpFS inodes

Browse source 
TmpFS inodes rely on the call to Inode::one_ref_left() to unregister
themselves from the inode cache in TmpFS.

When moving various kernel classes to ListedRefCounted for safe unref()
while participating on lists, I forgot to make ListedRefCounted check
for (and call) one_ref_left() & will_be_destroyed() on the CRTP class.
This commit is contained in:
Andreas Kling 2021-09-07 20:31:30 +02:00
parent 049d846eb9
commit 5159f64117
Notes: sideshowbarker 2024-07-18 04:29:32 +09:00
1 changed files with 11 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Kernel/Library/ListedRefCounted.h
View file

@ -20,15 +20,19 @@ class ListedRefCounted : public RefCountedBase {
public:
bool unref() const
{
bool did_hit_zero = T::all_instances().with([&](auto& list) {
if (deref_base())
return false;
list.remove(const_cast<T&>(static_cast<T const&>(*this)));
return true;
auto new_ref_count = T::all_instances().with([&](auto& list) {
auto new_ref_count = deref_base();
if (new_ref_count == 0)
list.remove(const_cast<T&>(static_cast<T const&>(*this)));
return new_ref_count;
});
if (did_hit_zero)
if (new_ref_count == 0) {
call_will_be_destroyed_if_present(static_cast<const T*>(this));
delete const_cast<T*>(static_cast<T const*>(this));
return did_hit_zero;
} else if (new_ref_count == 1) {
call_one_ref_left_if_present(static_cast<T const*>(this));
}
return new_ref_count == 0;
}
};