Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-10 01:51:03 +09:00
Code Activity

UI/Qt: Do not rely on the URL implicit constructors

Browse source
This commit is contained in:
Shannon Booth 2025-02-22 21:51:15 +13:00 • committed by Tim Flynn
parent 0f495421f1
commit 3fb9c37783
Notes: github-actions[bot] 2025-03-04 21:26:06 +00:00
6 changed files with 21 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

7
UI/Qt/Tab.cpp
View file

@ -8,6 +8,7 @@
#include <AK/TemporaryChange.h>
#include <LibGfx/ImageFormats/BMPWriter.h>
#include <LibURL/Parser.h>
#include <LibWeb/HTML/SelectedFile.h>
#include <LibWebView/SearchEngine.h>
#include <LibWebView/SourceHighlighter.h>
@ -466,8 +467,10 @@ Tab::Tab(BrowserWindow* window, RefPtr<WebView::WebContentClient> parent_client,
auto* search_selected_text_action = new QAction("&Search for <query>", this);
search_selected_text_action->setIcon(load_icon_from_uri("resource://icons/16x16/find.png"sv));
QObject::connect(search_selected_text_action, &QAction::triggered, this, [this]() {
auto url = MUST(String::formatted(Settings::the()->search_engine().query_url, URL::percent_encode(*m_page_context_menu_search_text)));
m_window->new_tab_from_url(URL::URL(url), Web::HTML::ActivateTab::Yes);
auto url_string = MUST(String::formatted(Settings::the()->search_engine().query_url, URL::percent_encode(*m_page_context_menu_search_text)));
auto url = URL::Parser::basic_parse(url_string);
VERIFY(url.has_value());
m_window->new_tab_from_url(url.release_value(), Web::HTML::ActivateTab::Yes);
});
auto take_screenshot = [this](auto type) {