Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-12 02:30:30 +09:00
Code Activity

LibCore: Always fail Account authentication on missing shadow entry

Browse source 
If a user is missing from /etc/shadow, we used to just allow anyone to
authenticate as that user without a password.

With this patch, authentication will instead always fail.
This commit is contained in:
Andreas Kling 2021-01-21 11:31:12 +01:00
parent 439f447ba8
commit 3b80358142
Notes: sideshowbarker 2024-07-18 23:01:30 +09:00
2 changed files with 9 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibCore/Account.cpp
View file

@ -102,6 +102,10 @@ Result<Account, String> Account::from_uid(uid_t uid)
bool Account::authenticate(const char* password) const bool Account::authenticate(const char* password) const
{ {
// If there was no shadow entry for this account, authentication always fails.
if (m_password_hash.is_null())
return false;
// An empty passwd field indicates that no password is required to log in. // An empty passwd field indicates that no password is required to log in.
if (m_password_hash.is_empty()) if (m_password_hash.is_empty())
return true; return true;
@ -206,7 +210,7 @@ void Account::load_shadow_file()
auto line = shadow_file->read_line(); auto line = shadow_file->read_line();
if (line.is_null()) if (line.is_null())
break; break;
auto parts = line.split(':'); auto parts = line.split(':', true);
if (parts.size() != 2) { if (parts.size() != 2) {
dbgln("Malformed shadow entry, ignoring."); dbgln("Malformed shadow entry, ignoring.");
continue; continue;

7
Userland/Libraries/LibCore/Account.h
View file

@ -51,7 +51,10 @@ public:
void set_password(const char* password); void set_password(const char* password);
void set_password_enabled(bool enabled); void set_password_enabled(bool enabled);
void delete_password(); void delete_password();
bool has_password() const { return !m_password_hash.is_empty(); }
// A null password means that this account was missing from /etc/shadow.
// It's considered to have a password in that case, and authentication will always fail.
bool has_password() const { return !m_password_hash.is_empty() || m_password_hash.is_null(); }
uid_t uid() const { return m_uid; } uid_t uid() const { return m_uid; }
gid_t gid() const { return m_gid; } gid_t gid() const { return m_gid; }
@ -73,8 +76,6 @@ private:
String m_username; String m_username;
// Contents of passwd field in passwd entry.
// Can be empty, "x", or contain a leading '!'
String m_password_hash; String m_password_hash;
uid_t m_uid { 0 }; uid_t m_uid { 0 };
gid_t m_gid { 0 }; gid_t m_gid { 0 };