1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-11 18:20:43 +09:00

LibWeb: Make factory method of HTML::History fallible

This commit is contained in:
Kenneth Myhra 2023-02-15 19:36:28 +01:00 committed by Linus Groh
parent 3941e64fde
commit 2f4db60c08
Notes: sideshowbarker 2024-07-17 22:41:14 +09:00
3 changed files with 4 additions and 4 deletions

View file

@ -2058,7 +2058,7 @@ CSS::StyleSheetList const& Document::style_sheets() const
JS::NonnullGCPtr<HTML::History> Document::history()
{
if (!m_history)
m_history = HTML::History::create(realm(), *this);
m_history = HTML::History::create(realm(), *this).release_value_but_fixme_should_propagate_errors();
return *m_history;
}

View file

@ -10,9 +10,9 @@
namespace Web::HTML {
JS::NonnullGCPtr<History> History::create(JS::Realm& realm, DOM::Document& document)
WebIDL::ExceptionOr<JS::NonnullGCPtr<History>> History::create(JS::Realm& realm, DOM::Document& document)
{
return realm.heap().allocate<History>(realm, realm, document).release_allocated_value_but_fixme_should_propagate_errors();
return MUST_OR_THROW_OOM(realm.heap().allocate<History>(realm, realm, document));
}
History::History(JS::Realm& realm, DOM::Document& document)

View file

@ -16,7 +16,7 @@ class History final : public Bindings::PlatformObject {
WEB_PLATFORM_OBJECT(History, Bindings::PlatformObject);
public:
static JS::NonnullGCPtr<History> create(JS::Realm&, DOM::Document&);
static WebIDL::ExceptionOr<JS::NonnullGCPtr<History>> create(JS::Realm&, DOM::Document&);
virtual ~History() override;