Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-08 05:27:14 +09:00
Code Activity

LibCore: Properly shutdown a socket on Windows

Browse source 
It fixes a bug in which ImageDecoder and RequestServer
do not exit because their connections don't close.

This makes the shutdown behavior match the Linux version,
which receives FD_READ | FD_HANGUP on socket close, and
TransportSocket::read_as_much_as_possible_without_blocking calls
schedule_shutdown when read from a socket returns 0 bytes.

On Windows, we have to explicitly call WIN32 shutdown to receive
notification FD_CLOSE.
This commit is contained in:
stasoid 2025-02-10 11:33:11 +05:00 • committed by Andrew Kaster
parent e1f70d532c
commit 26825b5865
Notes: github-actions[bot] 2025-02-10 19:47:21 +00:00
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibCore/EventLoopImplementationWindows.cpp
View file

@ -150,7 +150,7 @@ static int notifier_type_to_network_event(NotificationType type)
{
switch (type) {
case NotificationType::Read:
return FD_READ;
return FD_READ | FD_CLOSE;
case NotificationType::Write:
return FD_WRITE;
default: