From 21dbfd91141c177074c4ad27894deb01c24a7199 Mon Sep 17 00:00:00 2001 From: Andrew Kaster Date: Wed, 12 Feb 2025 05:20:20 -0700 Subject: [PATCH] LibTLS: Disable connect() on windows Until we implement a proper TCP and UDP connect with WinSock2, this won't be usable. Let's complain at runtime instead of link time. --- Libraries/LibTLS/Socket.cpp | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Libraries/LibTLS/Socket.cpp b/Libraries/LibTLS/Socket.cpp index 55d66a5b40e..42eb9350fb3 100644 --- a/Libraries/LibTLS/Socket.cpp +++ b/Libraries/LibTLS/Socket.cpp @@ -52,6 +52,12 @@ ErrorOr TLSv12::write_some(ReadonlyBytes bytes) ErrorOr> TLSv12::connect(ByteString const& host, u16 port, Options options) { +#ifdef AK_OS_WINDOWS + (void)host; + (void)port; + (void)options; + return AK::Error::from_string_literal("TODO: Unable to connect via hostname on Windows"); +#else auto promise = Core::Promise::construct(); OwnPtr tcp_socket = TRY(Core::TCPSocket::connect(host, port)); TRY(tcp_socket->set_blocking(false)); @@ -71,10 +77,17 @@ ErrorOr> TLSv12::connect(ByteString const& host, u16 port, tls_socket->on_connected = nullptr; tls_socket->m_context.should_expect_successful_read = true; return tls_socket; +#endif } ErrorOr> TLSv12::connect(Core::SocketAddress address, ByteString const& host, Options options) { +#ifdef AK_OS_WINDOWS + (void)address; + (void)host; + (void)options; + return AK::Error::from_string_literal("TODO: Unable to connect via address on Windows"); +#else auto promise = Core::Promise::construct(); OwnPtr tcp_socket = TRY(Core::TCPSocket::connect(address)); TRY(tcp_socket->set_blocking(false)); @@ -94,6 +107,7 @@ ErrorOr> TLSv12::connect(Core::SocketAddress address, Byte tls_socket->on_connected = nullptr; tls_socket->m_context.should_expect_successful_read = true; return tls_socket; +#endif } ErrorOr> TLSv12::connect(ByteString const& host, Core::Socket& underlying_stream, Options options)