Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-09 17:44:56 +09:00
Code Activity

LibGUI: Use on_up_pressed/on_down_pressed events in SpinBox

Browse source 
Fixes keyboard increment/decrement of SpinBox values.

After PR #2412 the TextBox class started not propagating arrow key
events to the parent widgets because it handles them itself now.
It also added two new events for these arrow keys, so use them instead
in SpinBox.
This commit is contained in:
Tibor Nagy 2020-09-23 18:57:39 +02:00 • committed by Andreas Kling
parent 5eefce11ed
commit 1fa5a526e8
Notes: sideshowbarker 2024-07-19 02:16:12 +09:00
2 changed files with 6 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Libraries/LibGUI/SpinBox.cpp
View file

@ -41,6 +41,12 @@ SpinBox::SpinBox()
else
m_editor->set_text(String::number(m_value));
};
m_editor->on_up_pressed = [this] {
set_value(m_value + 1);
};
m_editor->on_down_pressed = [this] {
set_value(m_value - 1);
};
m_increment_button = add<ControlBoxButton>(ControlBoxButton::UpArrow);
m_increment_button->set_focusable(false);
@ -88,20 +94,6 @@ void SpinBox::set_range(int min, int max)
update();
}
void SpinBox::keydown_event(KeyEvent& event)
{
if (event.key() == KeyCode::Key_Up) {
set_value(m_value + 1);
return;
}
if (event.key() == KeyCode::Key_Down) {
set_value(m_value - 1);
return;
}
event.ignore();
}
void SpinBox::mousewheel_event(MouseEvent& event)
{
set_value(m_value - event.wheel_delta());

1
Libraries/LibGUI/SpinBox.h
View file

@ -51,7 +51,6 @@ public:
protected:
SpinBox();
virtual void keydown_event(KeyEvent&) override;
virtual void mousewheel_event(MouseEvent&) override;
virtual void resize_event(ResizeEvent&) override;