From 188207ed79970e5b224f312e2de89d918367d8da Mon Sep 17 00:00:00 2001
From: Ali Mohammad Pur <ali.mpfard@gmail.com>
Date: Sun, 3 Apr 2022 18:06:18 +0430
Subject: [PATCH] AK: Make Vector<T>::{first,last}_matching() return
 Optional<T&>

These functions are _very_ misleading, as `first()` and `last()` return
references, but `{first,last}_matching()` return copies of the values.
This commit makes it so that they now return Optional<T&>, eliminating
the copy and the confusion.
---
 AK/Vector.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/AK/Vector.h b/AK/Vector.h
index 5b7ec2d9668..a261ac62411 100644
--- a/AK/Vector.h
+++ b/AK/Vector.h
@@ -163,7 +163,7 @@ public:
     VisibleType& last() { return at(size() - 1); }
 
     template<typename TUnaryPredicate>
-    Optional<VisibleType> first_matching(TUnaryPredicate predicate) requires(!contains_reference)
+    Optional<VisibleType&> first_matching(TUnaryPredicate predicate) requires(!contains_reference)
     {
         for (size_t i = 0; i < size(); ++i) {
             if (predicate(at(i))) {
@@ -174,7 +174,7 @@ public:
     }
 
     template<typename TUnaryPredicate>
-    Optional<VisibleType> last_matching(TUnaryPredicate predicate) requires(!contains_reference)
+    Optional<VisibleType&> last_matching(TUnaryPredicate predicate) requires(!contains_reference)
     {
         for (ssize_t i = size() - 1; i >= 0; --i) {
             if (predicate(at(i))) {