From 16743ee9d9d9e535e5eca6a74285a25ec9d44be7 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Fri, 30 May 2025 09:18:35 -0400 Subject: [PATCH] Meta: Invoke ninja directly instead of `cmake --build` This shaves about 10ms off an invocation of `ladybird.py build` on my machine, going from ~180ms to ~170ms. --- Meta/ladybird.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Meta/ladybird.py b/Meta/ladybird.py index 85d919e99f1..d4ad54d2df4 100755 --- a/Meta/ladybird.py +++ b/Meta/ladybird.py @@ -310,14 +310,15 @@ def ensure_ladybird_source_dir() -> Path: def build_main(build_dir: Path, target: Optional[str] = None, args: list[str] = []): build_args = [ - "cmake", - "--build", + "ninja", + "-C", str(build_dir), - "--parallel", + "-j", os.environ.get("MAKEJOBS", str(multiprocessing.cpu_count())), ] + if target: - build_args.extend(["--target", target]) + build_args.append(target) if args: build_args.append("--")