AK: Resolve clang-tidy warnings about unusual assignment operators

Either not returning *this, or in the case of Variant, not checking for self assignment. In AK::Atomic, we can't return *this due to the wrapper semantics Atomic implements.
Author: https://github.com/ADKaster Commit: 163367da39 Pull-request: https://github.com/SerenityOS/serenity/pull/10737 Reviewed-by: https://github.com/BenWiederhake Reviewed-by: https://github.com/PeterBindels-TomTom Reviewed-by: https://github.com/awesomekling Reviewed-by: https://github.com/dascandy Reviewed-by: https://github.com/trflynn89
2025-06-09 09:34:57 +09:00 · 2021-10-31 14:52:26 -06:00 · 2021-10-31 14:52:26 -06:00 · 163367da39 · 2024-07-18 01:08:05 +09:00
commit 163367da39
parent 22feb9d47b
3 changed files with 17 additions and 9 deletions
--- a/AK/Checked.h
+++ b/AK/Checked.h
@ -138,7 +138,8 @@ public:
    template<typename U>
    constexpr Checked& operator=(U value)
    {
-        return *this = Checked(value);
+        *this = Checked(value);
+        return *this;
    }

    constexpr Checked& operator=(const Checked& other) = default;