LibWeb/IDB: Resolve FIXME regarding removing from indecies

Author: https://github.com/stelar7
Commit: 13674c1b32
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4727
Reviewed-by: https://github.com/gmta ✅
Reviewed-by: https://github.com/shannonbooth

Libraries/LibWeb/IndexedDB/Internal/Algorithms.cpp

@@ -1318,7 +1318,10 @@ JS::Value delete_records_from_an_object_store(GC::Ref<ObjectStore> store, GC::Re
     // 1. Remove all records, if any, from store’s list of records with key in range.
     store->remove_records_in_range(range);
 
-    // FIXME: 2. For each index which references store, remove every record from index’s list of records whose value is in range, if any such records exist.
+    // 2. For each index which references store, remove every record from index’s list of records whose value is in range, if any such records exist.
+    for (auto const& [name, index] : store->index_set()) {
+        index->remove_records_with_value_in_range(range);
+    }
 
     // 3. Return undefined.
     return JS::js_undefined();

Libraries/LibWeb/IndexedDB/Internal/Index.cpp

@@ -122,4 +122,11 @@ void Index::store_a_record(IndexRecord const& record)
     });
 }
 
+void Index::remove_records_with_value_in_range(GC::Ref<IDBKeyRange> range)
+{
+    m_records.remove_all_matching([&](auto const& record) {
+        return range->is_in_range(record.value);
+    });
+}
+
 }

Libraries/LibWeb/IndexedDB/Internal/Index.h

@@ -45,6 +45,7 @@ public:
     GC::ConservativeVector<IndexRecord> first_n_in_range(GC::Ref<IDBKeyRange> range, Optional<WebIDL::UnsignedLong> count);
     u64 count_records_in_range(GC::Ref<IDBKeyRange> range);
     void store_a_record(IndexRecord const& record);
+    void remove_records_with_value_in_range(GC::Ref<IDBKeyRange> range);
 
     HTML::SerializationRecord referenced_value(IndexRecord const& index_record) const;