Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-08 05:27:14 +09:00
Code Activity

AK+Everywhere: Change StringView case conversions to return String

Browse source 
There's a bit of a UTF-8 assumption with this change. But nearly every
caller of these methods were immediately creating a String from the
resulting ByteString anyways.
This commit is contained in:
Timothy Flynn 2025-04-06 10:19:35 -04:00 • committed by Andreas Kling
parent 05627b6f45
commit 0a256b0a9a
Notes: github-actions[bot] 2025-04-07 15:45:50 +00:00
15 changed files with 57 additions and 56 deletions
Download patch file Download diff file Expand all files Collapse all files

32
AK/StringView.cpp
View file

@ -7,12 +7,14 @@
#include <AK/AnyOf.h>
#include <AK/ByteBuffer.h>
#include <AK/ByteString.h>
#include <AK/Enumerate.h>
#include <AK/Find.h>
#include <AK/FlyString.h>
#include <AK/Function.h>
#include <AK/String.h>
#include <AK/StringBuilder.h>
#include <AK/StringView.h>
#include <AK/Utf8View.h>
#include <AK/Vector.h>
#include <simdutf.h>
@ -204,17 +206,37 @@ bool StringView::is_ascii() const
return simdutf::validate_ascii(characters_without_null_termination(), length());
}
ByteString StringView::to_lowercase_string() const
String StringView::to_ascii_lowercase_string() const
{
return StringImpl::create_lowercased(characters_without_null_termination(), length()).release_nonnull();
VERIFY(Utf8View { *this }.validate());
String result;
MUST(result.replace_with_new_string({}, length(), [&](Bytes buffer) -> ErrorOr<void> {
for (auto [i, character] : enumerate(bytes()))
buffer[i] = static_cast<u8>(AK::to_ascii_lowercase(character));
return {};
}));
return result;
}
ByteString StringView::to_uppercase_string() const
String StringView::to_ascii_uppercase_string() const
{
return StringImpl::create_uppercased(characters_without_null_termination(), length()).release_nonnull();
VERIFY(Utf8View { *this }.validate());
String result;
MUST(result.replace_with_new_string({}, length(), [&](Bytes buffer) -> ErrorOr<void> {
for (auto [i, character] : enumerate(bytes()))
buffer[i] = static_cast<u8>(AK::to_ascii_uppercase(character));
return {};
}));
return result;
}
ByteString StringView::to_titlecase_string() const
String StringView::to_ascii_titlecase_string() const
{
return StringUtils::to_titlecase(*this);
}