mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-06-12 02:30:30 +09:00
LibWeb: Make XHR.response an actual XMLDocument for XML documents
Before this change, we were producing a generic DOM::Document, which was not distinguishable from an XMLDocument by IDL interface type.
This commit is contained in:
parent
2b343c9508
commit
0762388709
Notes:
sideshowbarker
2024-07-17 06:54:15 +09:00
Author: https://github.com/awesomekling
Commit: 0762388709
Pull-request: https://github.com/SerenityOS/serenity/pull/21362
5 changed files with 29 additions and 2 deletions
|
@ -1,5 +1,5 @@
|
|||
/*
|
||||
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
|
||||
* Copyright (c) 2020-2023, Andreas Kling <kling@serenityos.org>
|
||||
* Copyright (c) 2021-2023, Linus Groh <linusg@serenityos.org>
|
||||
* Copyright (c) 2022-2023, Luke Wilde <lukew@serenityos.org>
|
||||
* Copyright (c) 2022, Ali Mohammad Pur <mpfard@serenityos.org>
|
||||
|
@ -22,6 +22,7 @@
|
|||
#include <LibWeb/DOM/Event.h>
|
||||
#include <LibWeb/DOM/EventDispatcher.h>
|
||||
#include <LibWeb/DOM/IDLEventListener.h>
|
||||
#include <LibWeb/DOM/XMLDocument.h>
|
||||
#include <LibWeb/Fetch/BodyInit.h>
|
||||
#include <LibWeb/Fetch/Fetching/Fetching.h>
|
||||
#include <LibWeb/Fetch/Infrastructure/FetchAlgorithms.h>
|
||||
|
@ -317,7 +318,7 @@ void XMLHttpRequest::set_document_response()
|
|||
|
||||
// 6. Otherwise, let document be a document that represents the result of running the XML parser with XML scripting support disabled on xhr’s received bytes. If that fails (unsupported character encoding, namespace well-formedness error, etc.), then return null.
|
||||
else {
|
||||
document = DOM::Document::create(realm());
|
||||
document = DOM::XMLDocument::create(realm(), m_response->url().value_or({}));
|
||||
if (!Web::build_xml_document(*document, m_received_bytes)) {
|
||||
m_response_object = Empty {};
|
||||
return;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue