Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-09 09:34:57 +09:00
Code Activity

LibWeb: Ensure global objects are an event target

Browse source 
All global objects current need to be event targets so that they
can have events dispatched to them. This allows for removing of
verify_cast for these global objects.
This commit is contained in:
Shannon Booth 2024-12-03 02:37:33 +13:00 • committed by Andreas Kling
parent 6a85677f70
commit 05b4676917
Notes: github-actions[bot] 2024-12-02 23:20:48 +00:00
6 changed files with 11 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/HTML/ShadowRealmGlobalScope.h
View file

@ -26,8 +26,8 @@ public:
static GC::Ref<ShadowRealmGlobalScope> create(JS::Realm&); static GC::Ref<ShadowRealmGlobalScope> create(JS::Realm&);
virtual Bindings::PlatformObject& this_impl() override { return *this; } virtual DOM::EventTarget& this_impl() override { return *this; }
virtual Bindings::PlatformObject const& this_impl() const override { return *this; } virtual DOM::EventTarget const& this_impl() const override { return *this; }
// https://whatpr.org/html/9893/webappapis.html#dom-shadowrealmglobalscope-self // https://whatpr.org/html/9893/webappapis.html#dom-shadowrealmglobalscope-self
GC::Ref<ShadowRealmGlobalScope> self() GC::Ref<ShadowRealmGlobalScope> self()

3
Libraries/LibWeb/HTML/UniversalGlobalScope.cpp
View file

@ -198,8 +198,7 @@ void UniversalGlobalScopeMixin::notify_about_rejected_promises(Badge<EventLoop>)
m_about_to_be_notified_rejected_promises_list.clear(); m_about_to_be_notified_rejected_promises_list.clear();
// 4. Let global be settings object's global object. // 4. Let global be settings object's global object.
// We need this as an event target for the unhandledrejection event below auto& global = this_impl();
auto& global = verify_cast<DOM::EventTarget>(this_impl());
// 5. Queue a global task on the DOM manipulation task source given global to run the following substep: // 5. Queue a global task on the DOM manipulation task source given global to run the following substep:
queue_global_task(Task::Source::DOMManipulation, global, GC::create_function(realm.heap(), [this, &global, list = move(list)] { queue_global_task(Task::Source::DOMManipulation, global, GC::create_function(realm.heap(), [this, &global, list = move(list)] {

4
Libraries/LibWeb/HTML/UniversalGlobalScope.h
View file

@ -21,8 +21,8 @@ class UniversalGlobalScopeMixin {
public: public:
virtual ~UniversalGlobalScopeMixin(); virtual ~UniversalGlobalScopeMixin();
virtual Bindings::PlatformObject& this_impl() = 0; virtual DOM::EventTarget& this_impl() = 0;
virtual Bindings::PlatformObject const& this_impl() const = 0; virtual DOM::EventTarget const& this_impl() const = 0;
WebIDL::ExceptionOr<String> btoa(String const& data) const; WebIDL::ExceptionOr<String> btoa(String const& data) const;
WebIDL::ExceptionOr<String> atob(String const& data) const; WebIDL::ExceptionOr<String> atob(String const& data) const;

4
Libraries/LibWeb/HTML/Window.h
View file

@ -76,8 +76,8 @@ public:
virtual bool dispatch_event(DOM::Event&) override; virtual bool dispatch_event(DOM::Event&) override;
// ^WindowOrWorkerGlobalScopeMixin // ^WindowOrWorkerGlobalScopeMixin
virtual Bindings::PlatformObject& this_impl() override { return *this; } virtual DOM::EventTarget& this_impl() override { return *this; }
virtual Bindings::PlatformObject const& this_impl() const override { return *this; } virtual DOM::EventTarget const& this_impl() const override { return *this; }
// ^JS::Object // ^JS::Object
virtual JS::ThrowCompletionOr<bool> internal_set_prototype_of(JS::Object* prototype) override; virtual JS::ThrowCompletionOr<bool> internal_set_prototype_of(JS::Object* prototype) override;

4
Libraries/LibWeb/HTML/WindowOrWorkerGlobalScope.h
View file

@ -29,8 +29,8 @@ class WindowOrWorkerGlobalScopeMixin {
public: public:
virtual ~WindowOrWorkerGlobalScopeMixin(); virtual ~WindowOrWorkerGlobalScopeMixin();
virtual Bindings::PlatformObject& this_impl() = 0; virtual DOM::EventTarget& this_impl() = 0;
virtual Bindings::PlatformObject const& this_impl() const = 0; virtual DOM::EventTarget const& this_impl() const = 0;
// JS API functions // JS API functions
String origin() const; String origin() const;

4
Libraries/LibWeb/HTML/WorkerGlobalScope.h
View file

@ -43,8 +43,8 @@ public:
virtual ~WorkerGlobalScope() override; virtual ~WorkerGlobalScope() override;
// ^WindowOrWorkerGlobalScopeMixin // ^WindowOrWorkerGlobalScopeMixin
virtual Bindings::PlatformObject& this_impl() override { return *this; } virtual DOM::EventTarget& this_impl() override { return *this; }
virtual Bindings::PlatformObject const& this_impl() const override { return *this; } virtual DOM::EventTarget const& this_impl() const override { return *this; }
using UniversalGlobalScopeMixin::atob; using UniversalGlobalScopeMixin::atob;
using UniversalGlobalScopeMixin::btoa; using UniversalGlobalScopeMixin::btoa;