mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-06-11 18:20:43 +09:00
AK: Use AK_MAKE_DEFAULT_MOVABLE to avoid mistakes in default impls
This commit is contained in:
parent
3d3dfc8da8
commit
041f5e931d
Notes:
sideshowbarker
2024-07-17 04:34:25 +09:00
Author: https://github.com/BenWiederhake
Commit: 041f5e931d
Pull-request: https://github.com/SerenityOS/serenity/pull/19422
3 changed files with 4 additions and 16 deletions
|
@ -21,6 +21,7 @@ concept SeekableStreamLike = IsBaseOf<SeekableStream, T>;
|
||||||
template<typename T>
|
template<typename T>
|
||||||
class BufferedHelper {
|
class BufferedHelper {
|
||||||
AK_MAKE_NONCOPYABLE(BufferedHelper);
|
AK_MAKE_NONCOPYABLE(BufferedHelper);
|
||||||
|
AK_MAKE_DEFAULT_MOVABLE(BufferedHelper);
|
||||||
|
|
||||||
public:
|
public:
|
||||||
template<StreamLike U>
|
template<StreamLike U>
|
||||||
|
@ -30,19 +31,6 @@ public:
|
||||||
{
|
{
|
||||||
}
|
}
|
||||||
|
|
||||||
BufferedHelper(BufferedHelper&& other)
|
|
||||||
: m_stream(move(other.m_stream))
|
|
||||||
, m_buffer(move(other.m_buffer))
|
|
||||||
{
|
|
||||||
}
|
|
||||||
|
|
||||||
BufferedHelper& operator=(BufferedHelper&& other)
|
|
||||||
{
|
|
||||||
m_stream = move(other.m_stream);
|
|
||||||
m_buffer = move(other.m_buffer);
|
|
||||||
return *this;
|
|
||||||
}
|
|
||||||
|
|
||||||
template<template<typename> typename BufferedType>
|
template<template<typename> typename BufferedType>
|
||||||
static ErrorOr<NonnullOwnPtr<BufferedType<T>>> create_buffered(NonnullOwnPtr<T> stream, size_t buffer_size)
|
static ErrorOr<NonnullOwnPtr<BufferedType<T>>> create_buffered(NonnullOwnPtr<T> stream, size_t buffer_size)
|
||||||
{
|
{
|
||||||
|
|
|
@ -15,14 +15,12 @@ namespace AK {
|
||||||
|
|
||||||
class CircularBuffer {
|
class CircularBuffer {
|
||||||
AK_MAKE_NONCOPYABLE(CircularBuffer);
|
AK_MAKE_NONCOPYABLE(CircularBuffer);
|
||||||
|
AK_MAKE_DEFAULT_MOVABLE(CircularBuffer);
|
||||||
|
|
||||||
public:
|
public:
|
||||||
static ErrorOr<CircularBuffer> create_empty(size_t size);
|
static ErrorOr<CircularBuffer> create_empty(size_t size);
|
||||||
static ErrorOr<CircularBuffer> create_initialized(ByteBuffer);
|
static ErrorOr<CircularBuffer> create_initialized(ByteBuffer);
|
||||||
|
|
||||||
CircularBuffer(CircularBuffer&& other) = default;
|
|
||||||
CircularBuffer& operator=(CircularBuffer&& other) = default;
|
|
||||||
|
|
||||||
~CircularBuffer() = default;
|
~CircularBuffer() = default;
|
||||||
|
|
||||||
size_t write(ReadonlyBytes bytes);
|
size_t write(ReadonlyBytes bytes);
|
||||||
|
|
|
@ -36,6 +36,8 @@ public:
|
||||||
}
|
}
|
||||||
|
|
||||||
SourceGenerator(SourceGenerator&&) = default;
|
SourceGenerator(SourceGenerator&&) = default;
|
||||||
|
// Move-assign is undefinable due to 'StringBuilder& m_builder;'
|
||||||
|
SourceGenerator& operator=(SourceGenerator&&) = delete;
|
||||||
|
|
||||||
ErrorOr<SourceGenerator> fork()
|
ErrorOr<SourceGenerator> fork()
|
||||||
{
|
{
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue