Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-09 09:34:57 +09:00
Code Activity

Revert "CI: Only run builds after successful linting"

Browse source 
This reverts commits bf333eaea2 and
6f69a445bd.

The commit linter needs to run on event `pull_request_target` to have
access to its secret token, which means we cannot have a dependency on
that job from another workflow that is run as a result of the
`pull_request` event.

Additionally, the linters were no longer run for first-time
contributors. This isn't a huge problem but it was nice that a
preliminary check took place before running the full CI on their PRs.
This commit is contained in:
Jelle Raaijmakers 2025-03-20 23:54:44 +01:00 • committed by Jelle Raaijmakers
parent 357eeba49c
commit 01031bcccb
Notes: github-actions[bot] 2025-03-20 23:03:36 +00:00
3 changed files with 3 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

16
.github/workflows/ci.yml vendored
View file

@ -7,23 +7,9 @@ concurrency:
cancel-in-progress: true cancel-in-progress: true
jobs: jobs:
lint_code:
name: 'Lint Code'
uses: ./.github/workflows/lint-code.yml
lint_commits:
name: 'Lint Commits'
if: ${{ github.event_name == 'pull_request' }}
uses: ./.github/workflows/lint-commits.yml
# CI matrix - runs the job in lagom-template.yml with different configurations. # CI matrix - runs the job in lagom-template.yml with different configurations.
Lagom: Lagom:
needs: [lint_code, lint_commits] if: github.repository == 'LadybirdBrowser/ladybird'
if: |
always()
&& github.repository == 'LadybirdBrowser/ladybird'
&& needs.lint_code.result == 'success'
&& (needs.lint_commits.result == 'skipped' || needs.lint_commits.result == 'success')
strategy: strategy:
fail-fast: false fail-fast: false

3
.github/workflows/lint-code.yml vendored
View file

@ -1,7 +1,6 @@
name: Lint Code name: Lint Code
# Used by ci.yml on: [ push, pull_request ]
on: [workflow_call]
jobs: jobs:
lint: lint:

3
.github/workflows/lint-commits.yml vendored
View file

@ -1,7 +1,6 @@
name: Lint Commit Messages name: Lint Commit Messages
# Used by ci.yml on: [pull_request_target]
on: [workflow_call]
# Make sure to update Meta/lint-commit.sh to match this script when adding new checks! # Make sure to update Meta/lint-commit.sh to match this script when adding new checks!
# (… but don't accept overlong 'fixup!' commit descriptions.) # (… but don't accept overlong 'fixup!' commit descriptions.)